[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #27356 [Metrics/ExoneraTor]: Reduce database size and variance of query response times

#27356: Reduce database size and variance of query response times
--------------------------------+------------------------------
 Reporter:  karsten             |          Owner:  metrics-team
     Type:  enhancement         |         Status:  merge_ready
 Priority:  High                |      Milestone:
Component:  Metrics/ExoneraTor  |        Version:
 Severity:  Normal              |     Resolution:
 Keywords:                      |  Actual Points:
Parent ID:                      |         Points:
 Reviewer:  irl                 |        Sponsor:
--------------------------------+------------------------------
Changes (by irl):

 * status:  needs_review => merge_ready


Comment:

 Replying to [comment:9 karsten]:
 > Replying to [comment:8 irl]:
 > > I've checked it over for any obvious errors and the tests pass, but I
 notice that none of the tests actually use the database.
 >
 > That's true. Having more useful tests in ExoneraTor is, unfortunately, a
 little project of its own. We already have #24365 for this, but it's not
 as high priority as it could/should be. Let's try to leave room for these
 things in the next roadmap.

 Ok.

 > The commit message of 8159855 explains what the changes are all about.

 Ok. The changes look to implement what is described and the strategy looks
 good too.

 Thinking about handling schema changes, the comment says that
 `exonerator.sql` will go away and the new one will be modified to replace
 it. I've seen other software keep all the revisions and upgrade scripts
 since the beginning of the project (for example, observium) and
 installation starts with the original schema and then upgrades it. Perhaps
 this is useful to prevent bugs creeping in when the script is changed to
 replace the original script?

 Other than that, I think this is the limit of what I can review without
 standing up an instance to test on.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27356#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs