[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
[or-cvs] [tor/master 1/3] Don't unlock a new log until done logging the tor version.
Author: Nick Mathewson <nickm@xxxxxxxxxxxxxx>
Date: Mon, 25 Jan 2010 14:09:18 -0500
Subject: Don't unlock a new log until done logging the tor version.
Commit: ab87b61a9d1e18d85229c9fbf6c3862cea6a7bdd
This might please coverity scan.
---
src/common/log.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/src/common/log.c b/src/common/log.c
index ef65be8..dfea58f 100644
--- a/src/common/log.c
+++ b/src/common/log.c
@@ -678,13 +678,11 @@ add_file_log(const log_severity_list_t *severity, const char *filename)
logfiles->needs_close = 1;
lf = logfiles;
_log_global_min_severity = get_min_log_level();
- UNLOCK_LOGS();
if (log_tor_version(lf, 0) < 0) {
- LOCK_LOGS();
delete_log(lf);
- UNLOCK_LOGS();
}
+ UNLOCK_LOGS();
return 0;
}
--
1.6.5