Roger Dingledine wrote: > On Sat, Mar 06, 2010 at 02:06:00AM +0000, Jacob Appelbaum wrote: >> Modified: >> projects/android/trunk/Orbot/src/org/torproject/android/Orbot.java >> Log: >> Add FascistFirewall preference >> >> Modified: projects/android/trunk/Orbot/src/org/torproject/android/Orbot.java >> =================================================================== >> --- projects/android/trunk/Orbot/src/org/torproject/android/Orbot.java 2010-03-06 01:27:51 UTC (rev 21824) >> +++ projects/android/trunk/Orbot/src/org/torproject/android/Orbot.java 2010-03-06 02:06:00 UTC (rev 21825) >> @@ -460,6 +460,8 @@ > [snip] >> + String fascistFirewallPorts = >> + prefs.getString(PREF_FASCIST_FIREWALL_PORTS, "80,443"); > > From the Tor man page: > > FirewallPorts PORTS > A list of ports that your firewall allows you to connect to. > Only used when FascistFirewall is set. This option is depre- > cated; use ReachableAddresses instead. (Default: 80, 443) > > So, don't do that. :) > > You should also be aware that setting FascistFirewall 1 does not set > ReachableAddresses to "80, 443". It sets ReachableORAddresses to 443, > and ReachableDirAddresses to 80. So maybe you want to skip FascistFirewall > entirely and just set ReachableAddresses or not. > Good point! I'll re-code it and commit the diff in a bit. Best, Jake
Attachment:
signature.asc
Description: OpenPGP digital signature