[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-talk] Tor is out

On Thu, Apr 18, 2013 at 2:08 PM, Sebastian G. <bastik.tor>
<bastik.tor@xxxxxxxxxxxxxx> wrote:
> 18.04.2013 14:05, Roger Dingledine:
>> [...]
>>   o Major bugfixes (client-side privacy):
>>     - When we mark a circuit as unusable for new circuits, have it
>>       continue to be unusable for new circuits even if MaxCircuitDirtiness
>>       is increased too much at the wrong time, or the system clock jumps
>>       backwards. Fixes bug 6174; bugfix on 0.0.2pre26.
> Shouldn't this say "mark a circuit as unusable for new streams"?

Indeed it should.  With luck Roger will make the correction.

>> [...]
>>   o Minor bugfixes (syscalls):
>>     - Always check the return values of functions fcntl() and
>>       setsockopt(). We don't believe these are ever actually failing in
>>       practice, but better safe than sorry. Also, checking these return
>>       values should please analysis tools like Coverity. Patch from
>>       'flupzor'. Fixes bug 8206; bugfix on all versions of Tor.
> Sounds like a feature to me (since nothing was broken). Well I don't
> want to put this anywhere else or start a discussion, just adding a
> thought. (Since I'm writing anyway)

Heh. I think my reasoning for calling it a bugfix was that even though
_for all we know_, nothing was broken, that Tor's behavior here was
incorrect. (And for all we know, there's some weird platform somewhere
where one of our attempts to set CLOEXEC was failing for some odd

> [many awesome changes fell victim to trimming]

Thanks, Sebastian!

tor-talk mailing list