[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: 0.2.2.5-alpha doesn't know how to make libtor.a



     On Sun, 18 Oct 2009 19:05:28 -0400 Nick Mathewson <nickm@xxxxxxxxxxxxx>
wrote:
>On Sun, Oct 18, 2009 at 10:40:44AM -0500, Scott Bennett wrote:
>>      After running './configure CFLAGS="-march=prescott"', a 'make' in the
>> top (tor-0.2.2.5-alpha) directory did the following.
>
>I can't reproduce this; can you say more about your toolchain?  What
>OS are you getting this on?  Whose make are you using, and what

Script started on Mon Oct 19 10:16:24 2009
[hellas] 101 % which make
/usr/bin/make
[hellas] 102 % ls /usr/local/bin/*make
/usr/local/bin/automake@	/usr/local/bin/gmake*     /usr/local/bin/ppmmake*
/usr/local/bin/avimake*   	/usr/local/bin/imake*     /usr/local/bin/qmake*
/usr/local/bin/ccmake*    	/usr/local/bin/kmk_gmake* /usr/local/bin/tmake*
/usr/local/bin/cmake*     	/usr/local/bin/pbmmake*
[hellas] 103 % ls /usr/local/bin/automake*
/usr/local/bin/automake@         /usr/local/bin/automake-1.8*
/usr/local/bin/automake-1.10*    /usr/local/bin/automake-1.9*
/usr/local/bin/automake-1.4*     /usr/local/bin/automake-wrapper*
/usr/local/bin/automake-1.6*
[hellas] 104 % ls /usr/local/bin/autoconf*
/usr/local/bin/autoconf@         /usr/local/bin/autoconf-2.62*
/usr/local/bin/autoconf-2.13*    /usr/local/bin/autoconf-wrapper*
[hellas] 105 % ls /usr/local/bin/libtool*
/usr/local/bin/libtool*    	/usr/local/bin/libtoolize*
[hellas] 106 % gmake --version
GNU Make 3.81
Copyright (C) 2006  Free Software Foundation, Inc.
This is free software; see the source for copying conditions.
There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A
PARTICULAR PURPOSE.

This program built for i386-portbld-freebsd7.2
[hellas] 107 % lsl /usr/local/bin/auto{make,conf}
lrwxr-xr-x  1 root  wheel  16 Jun 25 01:59 /usr/local/bin/autoconf@ -> autoconf-wrapper
lrwxr-xr-x  1 root  wheel  16 Jun 25 02:00 /usr/local/bin/automake@ -> automake-wrapper
[hellas] 108 % libtool --version
ltmain.sh (GNU libtool) 2.2.6
Written by Gordon Matzigkeit <gord@xxxxxxxxxxxxxx>, 1996

Copyright (C) 2008 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
[hellas] 109 % uname -a
FreeBSD hellas 7.2-STABLE FreeBSD 7.2-STABLE #11: Sun Oct 18 09:33:26 CDT 2009     root@:/usr/obj/usr/src/sys/hellas  i386
[hellas] 110 % exit
exit

Script done on Mon Oct 19 10:20:25 2009

>version?  If it isn't gmake, does trying gmake[*] cause the problem to
>go away?

     I used the FreeBSD 7.2-STABLE make, which was recompiled as part of a
"make buildworld", etc. after cvsup-ing to get the latest FreeBSD RELENG_7
updates shortly beforehand.  Actually, what prompted the tor-0.2.2.5-alpha
build was the 5000 circuit times bug in 0.2.2.3-alpha, which was hit upon
startup after the "make installworld && mergemaster && reboot" sequence that
ends a full update of FreeBSD.  So that's what I used to start building tor,
but what was used at the lower levels (e.g., src/{common,or} I don't know.
I assume it was set by the configure script.
>
>Does anything happen if you edit src/or/Makefile.in to replace every
>reference to "./libtor.a" with one to "libtor.a" , then run configure
>again?

     I haven't tried it.  I may have a chance to play with it tonight or
tomorrow.
>
>[*] It wasn't our intention to require gmake; but learning that we
>    broke non-gmake builds would be a good step to diagnosing what's
>    wrong.
>
     Here are the diffs of src/or/Makefile from 0.2.2.3-alpha to
0.2.2.5-alpha.

18a19
> 
36,37d36
< TESTS = test$(EXEEXT)
< noinst_PROGRAMS = test$(EXEEXT)
50,53c49,54
< am__installdirs = "$(DESTDIR)$(bindir)"
< binPROGRAMS_INSTALL = $(INSTALL_PROGRAM)
< PROGRAMS = $(bin_PROGRAMS) $(noinst_PROGRAMS)
< am__test_SOURCES_DIST = buffers.c circuitbuild.c circuitlist.c \
---
> LIBRARIES = $(noinst_LIBRARIES)
> AR = ar
> ARFLAGS = cru
> libtor_a_AR = $(AR) $(ARFLAGS)
> libtor_a_LIBADD =
> am__libtor_a_SOURCES_DIST = buffers.c circuitbuild.c circuitlist.c \
60c61
< 	config_codedigest.c test_data.c test.c
---
> 	config_codedigest.c
63c64
< am__objects_3 = buffers.$(OBJEXT) circuitbuild.$(OBJEXT) \
---
> am_libtor_a_OBJECTS = buffers.$(OBJEXT) circuitbuild.$(OBJEXT) \
76,90c77,81
< am_test_OBJECTS = $(am__objects_3) test_data.$(OBJEXT) test.$(OBJEXT)
< test_OBJECTS = $(am_test_OBJECTS)
< test_DEPENDENCIES = ../common/libor.a ../common/libor-crypto.a \
< 	../common/libor-event.a
< test_LINK = $(CCLD) $(AM_CFLAGS) $(CFLAGS) $(test_LDFLAGS) $(LDFLAGS) \
< 	-o $@
< am__tor_SOURCES_DIST = buffers.c circuitbuild.c circuitlist.c \
< 	circuituse.c command.c config.c connection.c connection_edge.c \
< 	connection_or.c control.c cpuworker.c directory.c dirserv.c \
< 	dirvote.c dns.c dnsserv.c geoip.c hibernate.c main.c ntmain.c \
< 	networkstatus.c onion.c policies.c reasons.c relay.c \
< 	rendcommon.c rendclient.c rendmid.c rendservice.c rephist.c \
< 	router.c routerlist.c routerparse.c eventdns.c \
< 	config_codedigest.c tor_main.c
< am_tor_OBJECTS = $(am__objects_3) tor_main.$(OBJEXT)
---
> libtor_a_OBJECTS = $(am_libtor_a_OBJECTS)
> am__installdirs = "$(DESTDIR)$(bindir)"
> binPROGRAMS_INSTALL = $(INSTALL_PROGRAM)
> PROGRAMS = $(bin_PROGRAMS)
> am_tor_OBJECTS = tor_main.$(OBJEXT)
92,93c83,84
< tor_DEPENDENCIES = ../common/libor.a ../common/libor-crypto.a \
< 	../common/libor-event.a
---
> tor_DEPENDENCIES = ./libtor.a ../common/libor.a \
> 	../common/libor-crypto.a ../common/libor-event.a
103,104c94,95
< SOURCES = $(test_SOURCES) $(tor_SOURCES)
< DIST_SOURCES = $(am__test_SOURCES_DIST) $(am__tor_SOURCES_DIST)
---
> SOURCES = $(libtor_a_SOURCES) $(tor_SOURCES)
> DIST_SOURCES = $(am__libtor_a_SOURCES_DIST) $(tor_SOURCES)
109,113c100,104
< ACLOCAL = ${SHELL} /usr/home/hellas/bennett/src/tor/tor-0.2.2.3-alpha/missing --run aclocal-1.10
< AMTAR = ${SHELL} /usr/home/hellas/bennett/src/tor/tor-0.2.2.3-alpha/missing --run tar
< AUTOCONF = ${SHELL} /usr/home/hellas/bennett/src/tor/tor-0.2.2.3-alpha/missing --run autoconf
< AUTOHEADER = ${SHELL} /usr/home/hellas/bennett/src/tor/tor-0.2.2.3-alpha/missing --run autoheader
< AUTOMAKE = ${SHELL} /usr/home/hellas/bennett/src/tor/tor-0.2.2.3-alpha/missing --run automake-1.10
---
> ACLOCAL = ${SHELL} /usr/home/hellas/bennett/src/tor/tor-0.2.2.5-alpha/missing --run aclocal-1.10
> AMTAR = ${SHELL} /usr/home/hellas/bennett/src/tor/tor-0.2.2.5-alpha/missing --run tar
> AUTOCONF = ${SHELL} /usr/home/hellas/bennett/src/tor/tor-0.2.2.5-alpha/missing --run autoconf
> AUTOHEADER = ${SHELL} /usr/home/hellas/bennett/src/tor/tor-0.2.2.5-alpha/missing --run autoheader
> AUTOMAKE = ${SHELL} /usr/home/hellas/bennett/src/tor/tor-0.2.2.5-alpha/missing --run automake-1.10
142c133
< MAKEINFO = ${SHELL} /usr/home/hellas/bennett/src/tor/tor-0.2.2.3-alpha/missing --run makeinfo
---
> MAKEINFO = ${SHELL} /usr/home/hellas/bennett/src/tor/tor-0.2.2.5-alpha/missing --run makeinfo
169,173c160,164
< VERSION = 0.2.2.3-alpha
< abs_builddir = /usr/home/hellas/bennett/src/tor/tor-0.2.2.3-alpha/src/or
< abs_srcdir = /usr/home/hellas/bennett/src/tor/tor-0.2.2.3-alpha/src/or
< abs_top_builddir = /usr/home/hellas/bennett/src/tor/tor-0.2.2.3-alpha
< abs_top_srcdir = /usr/home/hellas/bennett/src/tor/tor-0.2.2.3-alpha
---
> VERSION = 0.2.2.5-alpha
> abs_builddir = /usr/home/hellas/bennett/src/tor/tor-0.2.2.5-alpha/src/or
> abs_srcdir = /usr/home/hellas/bennett/src/tor/tor-0.2.2.5-alpha/src/or
> abs_top_builddir = /usr/home/hellas/bennett/src/tor/tor-0.2.2.5-alpha
> abs_top_srcdir = /usr/home/hellas/bennett/src/tor/tor-0.2.2.5-alpha
200c191
< install_sh = $(SHELL) /usr/home/hellas/bennett/src/tor/tor-0.2.2.3-alpha/install-sh
---
> install_sh = $(SHELL) /usr/home/hellas/bennett/src/tor/tor-0.2.2.5-alpha/install-sh
218a210
> noinst_LIBRARIES = libtor.a
224c216
< COMMON_SRC = buffers.c circuitbuild.c circuitlist.c \
---
> libtor_a_SOURCES = buffers.c circuitbuild.c circuitlist.c \
234c226,229
< tor_SOURCES = $(COMMON_SRC) tor_main.c
---
> 
> #libtor_a_LIBADD = ../common/libor.a ../common/libor-crypto.a \
> #	../common/libor-event.a
> tor_SOURCES = tor_main.c
244,252c239
< tor_LDADD = ../common/libor.a ../common/libor-crypto.a \
< 	../common/libor-event.a \
< 	-lz -lm -levent -lssl -lcrypto  
< 
< test_SOURCES = $(COMMON_SRC) test_data.c test.c
< test_LDFLAGS =   \
<         -L/usr/local/lib
< 
< test_LDADD = ../common/libor.a ../common/libor-crypto.a \
---
> tor_LDADD = ./libtor.a ../common/libor.a ../common/libor-crypto.a \
289a277,283
> 
> clean-noinstLIBRARIES:
> 	-test -z "$(noinst_LIBRARIES)" || rm -f $(noinst_LIBRARIES)
> libtor.a: $(libtor_a_OBJECTS) $(libtor_a_DEPENDENCIES) 
> 	-rm -f libtor.a
> 	$(libtor_a_AR) libtor.a $(libtor_a_OBJECTS) $(libtor_a_LIBADD)
> 	$(RANLIB) libtor.a
313,318d306
< 
< clean-noinstPROGRAMS:
< 	-test -z "$(noinst_PROGRAMS)" || rm -f $(noinst_PROGRAMS)
< test$(EXEEXT): $(test_OBJECTS) $(test_DEPENDENCIES) 
< 	@rm -f test$(EXEEXT)
< 	$(test_LINK) $(test_OBJECTS) $(test_LDADD) $(LIBS)
364,365d351
< include ./$(DEPDIR)/test.Po
< include ./$(DEPDIR)/test_data.Po
430,502d415
< check-TESTS: $(TESTS)
< 	@failed=0; all=0; xfail=0; xpass=0; skip=0; ws='[	 ]'; \
< 	srcdir=$(srcdir); export srcdir; \
< 	list=' $(TESTS) '; \
< 	if test -n "$$list"; then \
< 	  for tst in $$list; do \
< 	    if test -f ./$$tst; then dir=./; \
< 	    elif test -f $$tst; then dir=; \
< 	    else dir="$(srcdir)/"; fi; \
< 	    if $(TESTS_ENVIRONMENT) $${dir}$$tst; then \
< 	      all=`expr $$all + 1`; \
< 	      case " $(XFAIL_TESTS) " in \
< 	      *$$ws$$tst$$ws*) \
< 		xpass=`expr $$xpass + 1`; \
< 		failed=`expr $$failed + 1`; \
< 		echo "XPASS: $$tst"; \
< 	      ;; \
< 	      *) \
< 		echo "PASS: $$tst"; \
< 	      ;; \
< 	      esac; \
< 	    elif test $$? -ne 77; then \
< 	      all=`expr $$all + 1`; \
< 	      case " $(XFAIL_TESTS) " in \
< 	      *$$ws$$tst$$ws*) \
< 		xfail=`expr $$xfail + 1`; \
< 		echo "XFAIL: $$tst"; \
< 	      ;; \
< 	      *) \
< 		failed=`expr $$failed + 1`; \
< 		echo "FAIL: $$tst"; \
< 	      ;; \
< 	      esac; \
< 	    else \
< 	      skip=`expr $$skip + 1`; \
< 	      echo "SKIP: $$tst"; \
< 	    fi; \
< 	  done; \
< 	  if test "$$failed" -eq 0; then \
< 	    if test "$$xfail" -eq 0; then \
< 	      banner="All $$all tests passed"; \
< 	    else \
< 	      banner="All $$all tests behaved as expected ($$xfail expected failures)"; \
< 	    fi; \
< 	  else \
< 	    if test "$$xpass" -eq 0; then \
< 	      banner="$$failed of $$all tests failed"; \
< 	    else \
< 	      banner="$$failed of $$all tests did not behave as expected ($$xpass unexpected passes)"; \
< 	    fi; \
< 	  fi; \
< 	  dashes="$$banner"; \
< 	  skipped=""; \
< 	  if test "$$skip" -ne 0; then \
< 	    skipped="($$skip tests were not run)"; \
< 	    test `echo "$$skipped" | wc -c` -le `echo "$$banner" | wc -c` || \
< 	      dashes="$$skipped"; \
< 	  fi; \
< 	  report=""; \
< 	  if test "$$failed" -ne 0 && test -n "$(PACKAGE_BUGREPORT)"; then \
< 	    report="Please report to $(PACKAGE_BUGREPORT)"; \
< 	    test `echo "$$report" | wc -c` -le `echo "$$banner" | wc -c` || \
< 	      dashes="$$report"; \
< 	  fi; \
< 	  dashes=`echo "$$dashes" | sed s/./=/g`; \
< 	  echo "$$dashes"; \
< 	  echo "$$banner"; \
< 	  test -z "$$skipped" || echo "$$skipped"; \
< 	  test -z "$$report" || echo "$$report"; \
< 	  echo "$$dashes"; \
< 	  test "$$failed" -eq 0; \
< 	else :; fi
< 
530d442
< 	$(MAKE) $(AM_MAKEFLAGS) check-TESTS
532c444
< all-am: Makefile $(PROGRAMS) $(HEADERS)
---
> all-am: Makefile $(LIBRARIES) $(PROGRAMS) $(HEADERS)
563c475
< clean-am: clean-binPROGRAMS clean-generic clean-noinstPROGRAMS \
---
> clean-am: clean-binPROGRAMS clean-generic clean-noinstLIBRARIES \
621,632c533,544
< .PHONY: CTAGS GTAGS all all-am check check-TESTS check-am clean \
< 	clean-binPROGRAMS clean-generic clean-noinstPROGRAMS ctags \
< 	distclean distclean-compile distclean-generic distclean-tags \
< 	distdir dvi dvi-am html html-am info info-am install \
< 	install-am install-binPROGRAMS install-data install-data-am \
< 	install-dvi install-dvi-am install-exec install-exec-am \
< 	install-html install-html-am install-info install-info-am \
< 	install-man install-pdf install-pdf-am install-ps \
< 	install-ps-am install-strip installcheck installcheck-am \
< 	installdirs maintainer-clean maintainer-clean-generic \
< 	mostlyclean mostlyclean-compile mostlyclean-generic pdf pdf-am \
< 	ps ps-am tags uninstall uninstall-am uninstall-binPROGRAMS
---
> .PHONY: CTAGS GTAGS all all-am check check-am clean clean-binPROGRAMS \
> 	clean-generic clean-noinstLIBRARIES ctags distclean \
> 	distclean-compile distclean-generic distclean-tags distdir dvi \
> 	dvi-am html html-am info info-am install install-am \
> 	install-binPROGRAMS install-data install-data-am install-dvi \
> 	install-dvi-am install-exec install-exec-am install-html \
> 	install-html-am install-info install-info-am install-man \
> 	install-pdf install-pdf-am install-ps install-ps-am \
> 	install-strip installcheck installcheck-am installdirs \
> 	maintainer-clean maintainer-clean-generic mostlyclean \
> 	mostlyclean-compile mostlyclean-generic pdf pdf-am ps ps-am \
> 	tags uninstall uninstall-am uninstall-binPROGRAMS
654c566
< or_sha1.i: $(tor_SOURCES) test_data.c test.c
---
> or_sha1.i: $(tor_SOURCES)
656c568
< 	  none $(tor_SOURCES) test_data.c test.c | sed -n 's/^\(.*\)$$/"\1\\n"/p' > or_sha1.i; \
---
> 	  none $(tor_SOURCES) | sed -n 's/^\(.*\)$$/"\1\\n"/p' > or_sha1.i; \
658c570
< 	  /usr/bin/openssl sha1 $(tor_SOURCES) test_data.c test.c | sed -n 's/SHA1(\(.*\))= \(.*\)/"\2  \1\\n"/p' > or_sha1.i; \
---
> 	  /usr/bin/openssl sha1 $(tor_SOURCES) | sed -n 's/SHA1(\(.*\))= \(.*\)/"\2  \1\\n"/p' > or_sha1.i; \


                                  Scott Bennett, Comm. ASMELG, CFIAG
**********************************************************************
* Internet:       bennett at cs.niu.edu                              *
*--------------------------------------------------------------------*
* "A well regulated and disciplined militia, is at all times a good  *
* objection to the introduction of that bane of all free governments *
* -- a standing army."                                               *
*    -- Gov. John Hancock, New York Journal, 28 January 1790         *
**********************************************************************
***********************************************************************
To unsubscribe, send an e-mail to majordomo@xxxxxxxxxxxxxx with
unsubscribe or-talk    in the body. http://archives.seul.org/or/talk/