Re: [pygame] BUG: floating point exception in pygame.transform.average

Re: [pygame] BUG: floating point exception in pygame.transform.average_color

To: pygame-users@xxxxxxxx

Subject: Re: [pygame] BUG: floating point exception in pygame.transform.average_color

From: Joost van Zwieten <joostvanzwieten@xxxxxxxxx>

Date: Wed, 5 Jun 2013 08:43:59 +0200

Delivered-to: archiver@xxxxxxxx

Delivered-to: pygame-users-outgoing@xxxxxxxx

Delivered-to: pygame-users@xxxxxxxx

Delivery-date: Wed, 05 Jun 2013 02:44:08 -0400

Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=j7U+AD1j7pe1++tC3lc4UV4lVbR5hTq7wBuh09P5Jm0=; b=MpuJzWBbrm2HDkZz5ifOSk0IiBBpW0y5LroU+opExEUTbXm13hxgoqfR3Sl7h0X9j1 Ep62VC2hvoF4bA6dY08Oc8qQ7jL37TaYgHPu9PY38E6vyDiEqe6z1AwDOXChBTWFoZ/p DkdHPiCeBXAivNe/TIAXCvRwaAu7ofQS4ASHaAdOosRbqYfZkOEkg05Ghw4re6vHEy/j TC6XVAnw0bqB5I9DMU9rPjNYmc51My5/yhkfXX1DERnB8PB4t8OJi58SagkmLsh1cpjA DG5mfR7Yq7hyira5dKLjEK8dHXFtvM1o9+EQ9X+dNCuK3oVhU4p3Jr1YsFSkkDKd4USn Yd9w==

In-reply-to: <CAEiAHjLnpyMrR4qB=M-UZAtgjLXgM8gChF=_Ysxgj3O7MyAUkg@xxxxxxxxxxxxxx>

References: <CAHuH2sYfSnb275s-N5Pvcs4W1wVqnYQdkjkUAVxebBo9SPfsOw@xxxxxxxxxxxxxx> <CAEiAHjLnpyMrR4qB=M-UZAtgjLXgM8gChF=_Ysxgj3O7MyAUkg@xxxxxxxxxxxxxx>

Reply-to: pygame-users@xxxxxxxx

Sender: owner-pygame-users@xxxxxxxx

I believe the attached patch solves the problem. If the rectangle lies completely outside the surface, average_color raises an exception. I'm not sure if I can write a unit test. Never done before.

On 4 June 2013 09:30, René Dudfield <renesd@xxxxxxxxx> wrote:

Thanks!

Can you turn it into a unit test?

On Mon, Jun 3, 2013 at 11:17 PM, Joost van Zwieten <joostvanzwieten@xxxxxxxxx> wrote:

Hi,

When trying to determine the average color of a surface inside a
rectangle which is located just outside the visible region, python
crashes with a floating point exception. A silly thing to do, but I
think that pygame should tell me I'm silly (-: Attached is a minimal
script which triggers the bug.

I am running debian wheezy, python 2.7.3-6 and pygame
1.9.1release+dfsg-8. If you need more info, please let me know.

Kind regards,

Joost van Zwieten

Attachment: average_color_bug_1.patch
Description: Binary data