Re: [tor-bugs] #15652 [Tor]: Base64 code cleanups.

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#15652: Base64 code cleanups.
-----------------------------+--------------------------------
     Reporter:  yawning      |      Owner:  yawning
         Type:  enhancement  |     Status:  needs_review
     Priority:  normal       |  Milestone:  Tor: 0.2.7.x-final
    Component:  Tor          |    Version:  Tor: unspecified
   Resolution:               |   Keywords:  tor-core
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+--------------------------------

Comment (by nickm):

 ba2485f7df51b2daafaff8567320c34a22731e8e
   * I like.

 e58d27f186ec5a8f67b4aee4513c3e02ff7f29b9
   * I think that ENCODE_OPENSSL is maybe not so great a name.  Maybe
 ENCODE_MULTILINE?
   * Style says to wrap macros in `do { ... } while (0)`.  Harmless in this
 case.
   * I wonder whether it's better to have the new behavior in a new
 function, so that less of the code needs to change.  But I'd say that it's
 our call in this case though.

 We should have an additional patch after this series that moves
 base{64,32}_encode/decode out of crypto into util or something.  Doesn't
 need to be now though.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/15652#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs