Re: [tor-bugs] #25814 [Core Tor/Tor]: Should Travis use "make distcheck"?

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#25814: Should Travis use "make distcheck"?
-----------------------------------------+---------------------------------
 Reporter:  nickm                        |          Owner:  nickm
     Type:  defect                       |         Status:  merge_ready
 Priority:  Medium                       |      Milestone:  Tor:
                                         |  0.3.4.x-final
Component:  Core Tor/Tor                 |        Version:
 Severity:  Normal                       |     Resolution:
 Keywords:  tor-ci, 034-roadmap-subtask  |  Actual Points:
Parent ID:  #25550                       |         Points:
 Reviewer:  isis                         |        Sponsor:
-----------------------------------------+---------------------------------

Comment (by nickm):

 Replying to [comment:5 isis]:
 > I'm sorry, I noticed the Rust breakage with 0.3.1 and 0.3.2 because I
 build .debs for my Qubes sys-tor VM, but I never said anything because I
 don't (want to) understand enough!^Wmore about Debian or its packaging
 system(s) and didn't really want to get into it. In retrospect, I probably
 should have filed a ticket.
 >
 > This patch LGTM!

 Great!  I'll plan to merge it once the team has had a chance to discuss
 the issue below.  Let's either do it at monday meeting, or schedule a time
 then to do it later.

 > Maybe we want to have conversations at some point about what Jenkins'
 function/purpose is (I thought it existed specifically to test packaging
 and more diverse architectures and platforms like arm and win32),

 From my point of view, it's okay if we rely on Jenkins to test packaging
 and diverse architectures, but ''only if we are looking at it and fixing
 the issues''. On the other hand, if we don't treat bugs found by Jenkins
 failures as "must fix", then I think we need to take more patches like
 this that add more configurations to Travis.

 I'm fine with either route: either checking Jenkins more frequently, or
 expanding the scope of what we do with Travis.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25814#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs