[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #25948 [Core Tor/Tor]: Run or_state_save as a mainloop event

#25948: Run or_state_save as a mainloop event
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:  nickm
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.4.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  034-roadmap-subtask,                 |  Actual Points:
  034-triage-20180328, 034-included-20180328     |
Parent ID:  #25375                               |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor8-can
-------------------------------------------------+-------------------------
Changes (by dgoulet):

 * status:  needs_review => needs_revision


Comment:

 {{{
 +  } else if (BUG(next_write <= now)) {
 +    return -1;
 }}}

 I guess this can happen if the clock jumped forward which will trigger the
 BUG() for a "valid" and recoverable use case no?

 Also, we should use `PERIODIC_EVENT_NO_UPDATE` instead of -1.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25948#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs