[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #25948 [Core Tor/Tor]: Run or_state_save as a mainloop event

#25948: Run or_state_save as a mainloop event
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:  nickm
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.4.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  034-roadmap-subtask,                 |  Actual Points:
  034-triage-20180328, 034-included-20180328     |
Parent ID:  #25375                               |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor8-can
-------------------------------------------------+-------------------------
Changes (by nickm):

 * status:  needs_revision => needs_review


Comment:

 I don't think that can happen: the next_write value is set by the
 or_state_save() function, which bases it on the value of "now" it takes as
 an argument.

 I've added a fixup to use PERIODIC_EVENT_NO_UPDATE, and explain the
 rationale for using BUG()

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25948#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs