Re: [tor-bugs] #33982 [Circumvention/Snowflake]: Simplify and refactor BytesSyncLogger

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#33982: Simplify and refactor BytesSyncLogger
-------------------------------------+-----------------------------
 Reporter:  dcf                      |          Owner:  dcf
     Type:  enhancement              |         Status:  merge_ready
 Priority:  Medium                   |      Milestone:
Component:  Circumvention/Snowflake  |        Version:
 Severity:  Normal                   |     Resolution:
 Keywords:                           |  Actual Points:
Parent ID:                           |         Points:
 Reviewer:  cohosh                   |        Sponsor:
-------------------------------------+-----------------------------
Changes (by cohosh):

 * status:  needs_review => merge_ready
 * reviewer:   => cohosh


Comment:

 Looks good to me.

 We actually ripped out bytes logging from the proxy
 [https://gitweb.torproject.org/pluggable-
 transports/snowflake.git/commit/?id=2e9e8071787398d9713395d94d93b5427ac8d452
 here] after doing some CPU profiling (see
 [https://trac.torproject.org/projects/tor/ticket/33211#comment:5
 #33211:comment:5]). The logging at the client is more responsible because
 it does I/O at regular time intervals and not inside the copy loop, but
 I'm not sure how necessary it is. I use it when testing locally. We could
 check to see whether client logging is going to `ioutil.Discard` and if it
 is, not bother with bytes logging?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33982#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs