[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #33982 [Circumvention/Snowflake]: Simplify and refactor BytesSyncLogger

#33982: Simplify and refactor BytesSyncLogger
-------------------------------------+-----------------------------
 Reporter:  dcf                      |          Owner:  dcf
     Type:  enhancement              |         Status:  merge_ready
 Priority:  Medium                   |      Milestone:
Component:  Circumvention/Snowflake  |        Version:
 Severity:  Normal                   |     Resolution:
 Keywords:                           |  Actual Points:
Parent ID:                           |         Points:
 Reviewer:  cohosh                   |        Sponsor:
-------------------------------------+-----------------------------

Comment (by dcf):

 Thanks for the review. Merged in [https://gitweb.torproject.org/pluggable-
 transports/snowflake.git/log/?id=73173cb6987dbf26fdb1036e4b7710c200f87141
 73173cb6987dbf26fdb1036e4b7710c200f87141].

 I don't think there's a need to avoid the byte logger. Here in the client
 it's ''O''(1) log lines per time interval, whereas in the proxy it was
 ''O''(number of messages sent and received), which is why it got expensive
 at high data rates. If the scrubber is the expensive part, we could
 disable log scrubbing entirely when logging to `ioutil.Discard`, rather
 than disabling some log lines.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33982#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs