[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #10362 [Pluggable transport]: Deploy FTE as a pluggable transport in PTTBBs

#10362: Deploy FTE as a pluggable transport in PTTBBs
-------------------------------------+-----------------
     Reporter:  asn                  |      Owner:
         Type:  task                 |     Status:  new
     Priority:  normal               |  Milestone:
    Component:  Pluggable transport  |    Version:
   Resolution:                       |   Keywords:
Actual Points:                       |  Parent ID:
       Points:                       |
-------------------------------------+-----------------

Comment (by kpdyer):

 I've tagged version 0.2.2 of fteproxy:
 https://github.com/kpdyer/fteproxy/tree/384a4b0ba5a5

 In this release I've done the following:

 * Removed the dependency on gmpy.
 * Changed the name of max_len to fixed_slice to better represent the
 actual meaning of the variable.
 * Added documentation to fte/encoder.py:RegexEncoderObject to explain the
 significance of fixed_slice.
 * Added documentation to fte/rank_unrank.h to explain the significance of
 _T and buildTable.
 * Changed all uses of [] to .at().
 * Resolved all TODOs.
 * Added verification on input to unrank to ensure the integer is within
 the expected range.
 * Added verification on input to rank to ensure the string is the exact
 size we expect.
 * Added verification on output of unrank/rank to ensure we properly
 traversed the DFA and are in a final state.
 * Added a try/catch around the call to re2 in attFstFromRegex.

 The changes above introduce the following question: If the inputs to
 (un)rank are out of range, then that indicates something has gone
 seriously wrong in the system. That is, we shouldn't ever invoke unrank on
 an integer that we don't know how to unrank. What's the "proper" PT way to
 handle this fatal error condition?

 I look forward to more feedback!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/10362#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs