Re: [tor-bugs] #3594 [Tor]: Add support for SOCKS parameters in Bridge and {Client, Server}TransportPlugin lines

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#3594: Add support for SOCKS parameters in Bridge and
{Client,Server}TransportPlugin lines
---------------------------+------------------------------------------------
 Reporter:  asn            |          Owner:                    
     Type:  defect         |         Status:  needs_review      
 Priority:  normal         |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor            |        Version:                    
 Keywords:  pt tor-bridge  |         Parent:  #7211             
   Points:                 |   Actualpoints:                    
---------------------------+------------------------------------------------

Comment(by andrea):

 In 89b21e929613e70be70e0a991bd65fb55b10a66b:
   - string_is_key_value() looks okay, but comment should describe the
 format it tries to recognize
     - NickM thinks it should use escaped()
   - Comment for tor_escape_str_for_socks_arg() mentions a 'set' param
 which
     doesn't actually exist.
   - The tor_escape_str_for_socsocksks_arg() is broken if you pass it the
 empty
     string (returns NULL).  Does this matter?
   - It is far from immediately obvious on reading that
 tor_escape_str_for_socsocksks_arg()
     NUL-terminates its output; change to tor_malloc() and explicitly put a
 '\0' in.
   - The comment for tor_escape_str_for_socsocksks_arg() should mention
 that it allocates a new
     string.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3594#comment:22>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs