Re: [tor-bugs] #12538 [Tor]: Make all relays automatically be dir caches

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#12538: Make all relays automatically be dir caches
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:
  cypherpunks            |     Status:  needs_review
         Type:  task     |  Milestone:  Tor: 0.2.6.x-final
     Priority:  normal   |    Version:  Tor: unspecified
    Component:  Tor      |   Keywords:  tor-guard, tor-relay, prop237,
   Resolution:           |  026-triaged-1, sebastian-review
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+-------------------------------------------------

Comment (by Sebastian):

 Hey, I'm not finding much here. :)

 In the spec, you should be concrete with the version that introduced it,
 like "versions until 0.2.6.2-alpha don't recognize this".

 In the code, I noticed this comment:

 {{{
 +  /** True iff this router included "tunnelled-dir-server" in its
 descriptor,
 +   * implies it accepts tunnelled directory requests, or it advertised
 +   * dir_port > 0. */
 }}}
 should the "implies" be implying? When I read it first I wonder if there
 are three ways this can be true.

 I haven't yet review the test changes, only the code. Will hopefully get
 to the tests tonight

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12538#comment:40>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs