[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #8400 [Tor Browser]: Torbutton's browsing history pref seems to require restart

#8400: Torbutton's browsing history pref seems to require restart
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:  tbb-team
  mikeperry              |     Status:  needs_revision
         Type:  defect   |  Milestone:
     Priority:  major    |    Version:
    Component:  Tor      |   Keywords:  tbb-rebase-regression, tbb-
  Browser                |  usability, tbb-torbutton, MikePerry201502,
   Resolution:           |  TorBrowserTeam201502
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+-------------------------------------------------
Changes (by brade):

 * keywords:
     tbb-rebase-regression, tbb-usability, tbb-torbutton, MikePerry201502,
     TorBrowserTeam201502R
     =>
     tbb-rebase-regression, tbb-usability, tbb-torbutton, MikePerry201502,
     TorBrowserTeam201502
 * status:  needs_review => needs_revision


Comment:

 Mark and I reviewed your fix.  It looks good.  Just a few minor comments:

 - There is an extra blank line after the definition of Cc and Ci.
 - Please use the Cc and Ci constants in the "var sb = ..." statement.
 - You could replace more occurrences of "var" with "let".
 - Remove the extra '.' at the end of your commit message.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8400#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs