[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #13882 [Tor Browser]: Circuit display fails to show new bridge settings

#13882: Circuit display fails to show new bridge settings
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:  arthuredelstein
  arthuredelstein        |     Status:  needs_review
         Type:  defect   |  Milestone:
     Priority:  normal   |    Version:
    Component:  Tor      |   Keywords:  tbb-torbutton, tbb-circuit-display,
  Browser                |  TorBrowserTeam201502R, PearlCrescent201502R
   Resolution:           |  Parent ID:
Actual Points:           |
       Points:           |
-------------------------+-------------------------------------------------

Comment (by mcs):

 Kathy and I reviewed your patch.  This looks like a nice improvement!  We
 have a few questions / comments:
 * In the getBridge function, are you certain that bridge.ID will be upper
 case?
 * In info.bridgeParser, do we need to add parser support for IPv6
 addresses?
 * Will "vanilla" ever show up in the circuit display?  I could not make
 that happen during testing. Tor transport (aka vanilla bridges) resulted
 in a generic display that looked like "(Unknown country)(IP unknown)".
 * For meek, I expected the circuit display to show 'Bridge: meek" or
 similar but I saw the same generic display as for Tor bridges.
 * Inside info.getMultipleResponseValues, I think you can remove
 "filter(utils.identity)" (unless I misunderstand something, it does not
 change the array that is returned).

 Also, this may already be covered in a different ticket, but after I did
 "New Tor Circuit for this Site" I had no circuit display.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13882#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs