[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #13882 [Tor Browser]: Circuit display fails to show new bridge settings

#13882: Circuit display fails to show new bridge settings
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:  arthuredelstein
  arthuredelstein        |     Status:  needs_review
         Type:  defect   |  Milestone:
     Priority:  normal   |    Version:
    Component:  Tor      |   Keywords:  tbb-torbutton, tbb-circuit-display,
  Browser                |  TorBrowserTeam201502R, PearlCrescent201502R
   Resolution:           |  Parent ID:
Actual Points:           |
       Points:           |
-------------------------+-------------------------------------------------

Comment (by arthuredelstein):

 Replying to [comment:6 mcs]:
 > Kathy and I reviewed your patch.  This looks like a nice improvement!
 We have a few questions / comments:

 Thanks for the review!

 > * In the getBridge function, are you certain that bridge.ID will be
 upper case?

 Fixed.

 > * In info.bridgeParser, do we need to add parser support for IPv6
 addresses?

 Likely a useful thing to add in the future. I am adding a ticket: #14939

 > * Will "vanilla" ever show up in the circuit display?  I could not make
 that happen during testing. Tor transport (aka vanilla bridges) resulted
 in a generic display that looked like "(Unknown country)(IP unknown)".

 I made a modification so that a "vanilla" bridge just shows the word
 "(Bridge)" after the country name. For example, I am now seeing Japan
 (Bridge). I'm not sure why you have seen "Unknown country (IP unknown)".

 > * For meek, I expected the circuit display to show 'Bridge: meek" or
 similar but I saw the same generic display as for Tor bridges.

 Yes, meek is a special problem and I need to work on it some more. I'm
 putting it in a separate ticket so as not to hold up the rest of this fix:
 #14937.

 > * Inside info.getMultipleResponseValues, I think you can remove
 "filter(utils.identity)" (unless I misunderstand something, it does not
 change the array that is returned).

 `.filter(utils.identity)` was added to drop items that are null.

 > Also, this may already be covered in a different ticket, but after I did
 "New Tor Circuit for this Site" I had no circuit display.

 Both my patches for #9442 and #14866 are necessary to get this working.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13882#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs