[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #8786 [Tor]: Add extra-info line that tracks the number of consensus downloads of each pluggable transports

#8786: Add extra-info line that tracks the number of consensus downloads of each
pluggable transports
-------------------------------------------------+-------------------------
 Reporter:  asn                                  |          Owner:
     Type:  enhancement                          |         Status:
 Priority:  Low                                  |  needs_review
Component:  Tor                                  |      Milestone:  Tor:
 Severity:  Normal                               |  0.2.8.x-final
 Keywords:  pt, tor-bridge, flashproxy,          |        Version:
  026-triaged-1, 026-deferrable,                 |     Resolution:
  027-triaged-1-out                              |  Actual Points:
Parent ID:                                       |         Points:
  Sponsor:                                       |
-------------------------------------------------+-------------------------

Comment (by dcf):

 I don't know the code, but I read through the patch.

 The patch uses the `"%d"` format specifier for the output of
 `round_to_next_multiple_of` in `geoip_get_requests_by_transport_history`,
 but uses the `"%u"` format specifier in
 `geoip_get_requests_by_version_history`.

 It surprised me that `geoip_get_requests_by_version_history` returns
 `NULL` when both the v4 and v6 counts are 0, instead of returning
 "v4=0,v6=0". But I guess it matches what
 `geoip_get_requests_by_transport_history` does when all counts are 0.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8786#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs