[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #8786 [Tor]: Add extra-info line that tracks the number of consensus downloads of each pluggable transports
#8786: Add extra-info line that tracks the number of consensus downloads of each
pluggable transports
-------------------------------------------------+-------------------------
Reporter: asn | Owner:
Type: enhancement | Status:
Priority: Low | needs_review
Component: Tor | Milestone: Tor:
Severity: Normal | 0.2.8.x-final
Keywords: pt, tor-bridge, flashproxy, | Version:
026-triaged-1, 026-deferrable, | Resolution:
027-triaged-1-out | Actual Points:
Parent ID: | Points:
Sponsor: |
-------------------------------------------------+-------------------------
Comment (by karsten):
Replying to [comment:10 dcf]:
> I don't know the code, but I read through the patch.
Thanks! Much appreciated! (Please let me know if you have a branch for
me to review, and I'll take a look.)
> The patch uses the `"%d"` format specifier for the output of
`round_to_next_multiple_of` in `geoip_get_requests_by_transport_history`,
but uses the `"%u"` format specifier in
`geoip_get_requests_by_version_history`.
Agreed. Changed to `"%u"` in both cases.
> It surprised me that `geoip_get_requests_by_version_history` returns
`NULL` when both the v4 and v6 counts are 0, instead of returning
"v4=0,v6=0". But I guess it matches what
`geoip_get_requests_by_transport_history` does when all counts are 0.
Right, I think returning a count of 0 has little value. But I went even
further and changed "v4=8,v6=0" to just "v4=8", because that "v6=0"
doesn't provide much value, either.
Changes pushed as separate commit to the same branch. Thanks again!
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8786#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs