[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #20765 [Metrics/metrics-lib]: adapt to new lines in votes and consensus and make the adaption to protocol changes easier
#20765: adapt to new lines in votes and consensus and make the adaption to protocol
changes easier
---------------------------------+-----------------------------------
Reporter: iwakeh | Owner: metrics-team
Type: enhancement | Status: needs_review
Priority: Medium | Milestone: metrics-lib 1.6.0
Component: Metrics/metrics-lib | Version:
Severity: Normal | Resolution:
Keywords: | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
---------------------------------+-----------------------------------
Comment (by iwakeh):
Replying to [comment:5 karsten]:
> And there's now [https://gitweb.torproject.org/user/karsten/metrics-
lib.git/commit/?h=task-20765-2&id=3a990a48ca23ff4c5069d50b170761fadeb49018
another commit] for the second half of the changes above. Please review!
Tests and checks pass.
For a boolean return value I'd expect "is*" and not "get*", i.e.,
`isSharedRandParticipate` instead of`getSharedRandParticipate`.
===
One more comment on the previous commit:
The new `private void parse*` methods just set a global variable each; why
not have the `this.* = ParseHelper.parseProtocolVersions(line, line,
parts);` lines in the switch stmt w/o the method calls?
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20765#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs