Re: [tor-bugs] #20765 [Metrics/metrics-lib]: adapt to new lines in votes and consensus and make the adaption to protocol changes easier

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#20765: adapt to new lines in votes and consensus and make the adaption to protocol
changes easier
---------------------------------+-----------------------------------
 Reporter:  iwakeh               |          Owner:  metrics-team
     Type:  enhancement          |         Status:  needs_review
 Priority:  Medium               |      Milestone:  metrics-lib 1.6.0
Component:  Metrics/metrics-lib  |        Version:
 Severity:  Normal               |     Resolution:
 Keywords:                       |  Actual Points:
Parent ID:                       |         Points:
 Reviewer:                       |        Sponsor:
---------------------------------+-----------------------------------

Comment (by karsten):

 Replying to [comment:6 iwakeh]:
 > Replying to [comment:4 karsten]:
 > > Please review [https://gitweb.torproject.org/user/karsten/metrics-
 lib.git/commit/?h=task-20765-2&id=fd54cffa9335cac2f8c09398da34b85d4fabfd5d
 this commit] for the first half of the changes above.  Shared randomness
 follows later today, I hope.
 >
 > Tests and checks pass.

 Great!

 > For checking the upper limit it would be a little more readable to use
 `0x1_0000_0000L` instead of 4294967296L.

 Changed.

 > (Just a thought, should `Number` be used instead of `Long` as the
 protocol numbers have unsigned int range?)

 Hmm, can you elaborate?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20765#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs