Re: [tor-bugs] #1368 [Tor Client]: Implement a heartbeat log message

["Tor Bug Tracker & Wiki" <torproject-admin@xxxxxxxxxxxxxx>]

#1368: Implement a heartbeat log message
--------------------------------+-------------------------------------------
 Reporter:  Sebastian           |         Type:  enhancement
   Status:  needs_review        |     Priority:  major      
Milestone:  Tor: 0.2.3.x-final  |    Component:  Tor Client 
  Version:  0.2.0.31            |   Resolution:  None       
 Keywords:                      |       Parent:             
--------------------------------+-------------------------------------------

Comment(by nickm):

 Re-reading now:

   * It looks like the libtor_a_SOURCES and noinst_HEADERS lists are now
 out-of-order.
   * make check-spaces doesn't pass.
   * The style still isn't K&R.
   * commit messages that don't say anything. (e.g., "Various fixes".)
   * By convention, we try to use "foo_out" as the name for an argument
 that gets changed by a function.  get_traffic_stats's arguments should
 probably then be called "n_read_out" and "n_written_out".
   * secs_to_uptime shouldn't take uptime_string as an argument; it makes
 no sense to do so.  (See asprintf documentatino).
   * In bytes_to_bandwidth you're going to asprintf a uint64_t, you need to
 use the  U64_PRINTF_ARG to make sure it's cast to the right type.
   * In log_heartbeat, nothing frees any of the allocated strings.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1368#comment:19>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs