[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #1368 [Tor Client]: Implement a heartbeat log message
#1368: Implement a heartbeat log message
--------------------------------+-------------------------------------------
Reporter: Sebastian | Type: enhancement
Status: closed | Priority: major
Milestone: Tor: 0.2.3.x-final | Component: Tor Client
Version: 0.2.0.31 | Resolution: not a bug
Keywords: | Parent:
--------------------------------+-------------------------------------------
Changes (by asn):
* status: needs_review => closed
* resolution: None => not a bug
Comment:
Replying to [comment:19 nickm]:
> Re-reading now:
>
> * It looks like the libtor_a_SOURCES and noinst_HEADERS lists are now
out-of-order.
> * make check-spaces doesn't pass.
> * The style still isn't K&R.
> * commit messages that don't say anything. (e.g., "Various fixes".)
> * By convention, we try to use "foo_out" as the name for an argument
that gets changed by a function. get_traffic_stats's arguments should
probably then be called "n_read_out" and "n_written_out".
> * secs_to_uptime shouldn't take uptime_string as an argument; it makes
no sense to do so. (See asprintf documentatino).
> * In bytes_to_bandwidth you're going to asprintf a uint64_t, you need
to use the U64_PRINTF_ARG to make sure it's cast to the right type.
> * In log_heartbeat, nothing frees any of the allocated strings.
>
Latest commit addresses those issues [1].
Thanks for the review.
I'm removing the needs_review label, since next step is to implement the
custom message feature and not code review.
[1]:
http://gitorious.org/heartbeat/heartbeat/commit/5098c0b700a027fcedd4cfd8b08b3f59ac5fe91c
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1368#comment:20>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs