[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #12585 [Tor]: Implement new option SocksSocket

#12585: Implement new option SocksSocket
-----------------------------+--------------------------------
     Reporter:  ioerror      |      Owner:
         Type:  enhancement  |     Status:  needs_revision
     Priority:  normal       |  Milestone:  Tor: 0.2.6.x-final
    Component:  Tor          |    Version:  Tor: unspecified
   Resolution:               |   Keywords:  026-triaged-1
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+--------------------------------

Comment (by nickm):

 Replying to [comment:44 ioerror]:
 > Replying to [comment:43 nickm]:
 > >
 > > Throughout:
 > >
 > >   * Looks nice!  Much simpler now.
 >
 > Agreed - a lot of refactoring that makes it easier to read!
 >
 > >
 > >   - This is probably gonna break on windows: I don't think they have
 AF_UNIX, and at least address.c uses AF_UNIX unconditionally. I can clean
 it up if you want, or you can if you've got mingw cross-compilation stuff
 installed.
 >
 > I think it would be great if anyone with Windows could make this work.
 It would remove lots of local firewall issues, I think. I think the proper
 way to implement it would be to use a named pipe (
 http://msdn.microsoft.com/en-
 us/library/windows/desktop/aa365590%28v=vs.85%29.aspx ) and it would
 effectively be the same feature.

 Not that simple, I'm afraid.  Named pipes don't interoperate with sockets
 in the way we're using them.  You'd need to do some low-level hacking on
 the async io layer.  (Not impossible, but likely to involve complexity.)

 In other words "Good idea, but a bit tricky. Somebody should open a new
 ticket so this one doesn't block on it." ;)

  [...]
 > In some kind of ideal world, I like the idea of shipping TBB with
 Firefox completely sandboxed from making TCP/IP connection on two of our
 three platforms. The third one being windows, of course. I guess that
 depends on discovering if NamedPipes will work or not.

 Same as above wrt "Good idea but a bit tricky. Somebody should open a new
 ticket so this one doesn't block on it." ;)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12585#comment:45>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs