[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #20994 [Metrics/Onionoo]: invalid first_seen timestamp on bridges
#20994: invalid first_seen timestamp on bridges
-----------------------------+------------------------------
Reporter: cypherpunks | Owner: metrics-team
Type: defect | Status: needs_review
Priority: Medium | Milestone:
Component: Metrics/Onionoo | Version:
Severity: Normal | Resolution:
Keywords: | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
-----------------------------+------------------------------
Comment (by karsten):
Replying to [comment:4 iwakeh]:
> The reasoning in comment:3 makes sense; the code seems to do what is
suggested, but test(s) missing.
Cool, thanks for looking! There are indeed no tests for this class. But
I'm afraid it's a small project to start writing tests for this class now,
and that shouldn't block the bugfix.
> Couldn't there also be relays affected, b/c of the cached descriptor
imports?
Good question. The answer is that relays are not affected, because
`processRelayServerDescriptor()` did ''not'' contain a line
`this.updatedNodes.add(fingerprint);` as it was contained in
`processBridgeServerDescriptor()`. We only put relay fingerprints into
that set that we saw in consensuses, and that's how they all got valid
`first_seen` timestamps.
So, good to merge?
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20994#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs