[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #24902 [Core Tor/Tor]: Denial of Service mitigation subsystem

#24902: Denial of Service mitigation subsystem
-------------------------------------------------+-------------------------
 Reporter:  dgoulet                              |          Owner:  dgoulet
     Type:  enhancement                          |         Status:
                                                 |  merge_ready
 Priority:  Very High                            |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  ddos, tor-relay, review-group-30,    |  Actual Points:
  029-backport, 031-backport, 032-backport,      |
  review-group-31                                |
Parent ID:                                       |         Points:
 Reviewer:  arma                                 |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by dgoulet):

 * status:  needs_review => merge_ready


Comment:

 Replying to [comment:50 teor]:
 > "dos.h" already exists in some Windows environments. We might want to
 pick another name.

 We don't use it in the tor code base so I doubt there could be any kind of
 confusion with the `dos.h` Windows?... Maybe if we would use `#include
 <dos.h>` ?

 Else we could rename with something like `defense.c` or `mitigation.c` or
 dunno... ? I think we can do this after the upstream merge.

 > (A) I think this one is missing a !.

 Indeed. Fixup: 12761ce3685c9d57

 > (C), it wants a changes file. Here's a start:

 Very nice! I've added it in commit: ea5d3bf4d5188511

 > I pushed a commit to my ticket24902_029_04-fixup branch that you might
 like -- it cleans up the heartbeat messages a bit.

 Very nice again, I've cherry-picked it in commit: 8c6833be7d6e631d

 Ok, I think with teor and arma happy now, we can proceed with a
 `merge_ready` state. For this, I've created a _05 branch squashing the _04
 branch fixup commits and created an OnionGit MR in case Nick wants to
 comment on it.

 Branch: `ticket24902_029_05`
 Oniongit: https://oniongit.eu/dgoulet/tor/merge_requests/20

 Then we have an 0.3.3 branch as well (based on latest master) in case Nick
 wants to pick that one and not deal with the 029 merge into master.

 Branch: `ticket24902_033_02`

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24902#comment:54>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs