[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #28716 [Applications/Tor Browser]: Create a mingw-w64-clang project
#28716: Create a mingw-w64-clang project
-------------------------------------------------+-------------------------
Reporter: gk | Owner: tbb-
| team
Type: task | Status:
| needs_revision
Priority: High | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: tbb-rbm, TorBrowserTeam201901, | Actual Points:
GeorgKoppen201901 |
Parent ID: #28238 | Points:
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Comment (by tom):
Replying to [comment:11 gk]:
> Why would we need 1481633 fixed on esr60 if the reason it came up
(1471132) did not land on esr60? Moreover, from skimming that bug it seems
to me that's an issue we should hit during compilation, if at all, which I
did not.
Hrm. nsModule compilation might have been broken before 1471132 came
along; and we just didn't have a mingw-clang build consistently working
then.
A few different things can go wrong with nsModules: at compile time you
could have missing symbols. Or at runtime, the resulting symbols in the
binary might not be packed or ordered correctly. We do some ugly stuff
were we basically make an array in the resulting binary, and then iterate
through it like it was an array. If the layout, padding, or order is
wrong, the code assumptions break and you get a runtime problem.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28716#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs