[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #28716 [Applications/Tor Browser]: Create a mingw-w64-clang project
#28716: Create a mingw-w64-clang project
-------------------------------------------------+-------------------------
Reporter: gk | Owner: tbb-
| team
Type: task | Status:
| needs_revision
Priority: High | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: tbb-rbm, TorBrowserTeam201901, | Actual Points:
GeorgKoppen201901 |
Parent ID: #28238 | Points:
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Comment (by gk):
Replying to [comment:14 tom]:
> Replying to [comment:13 gk]:
> > I've updated `bug_28716_v2` to add the changes coming with bug 1506450
and rebased `bug_28238_v2` on top of it (after adding the mozconfig
changes due to the fix for 1506450). 64bit is still compiling fine, I am
looking into the header path issue for 32bit.
> >
> > FWIW: I have not patched our Firefox related build instructions so
that they bundle the urct dlls instead of msvcr100 yet. That will happen
in #28238.
>
> I built
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c7ca3a0df8ec659bbe75322bea4ab296a91a1c50
with the toolchain from this comment.
>
> It builds on top of d90df493b2ecb5267009789a47559ebe534d9d87 from above
and includes these two patches:
> https://hg.mozilla.org/try/rev/9857214ebf6b (use your toolchain)
> https://hg.mozilla.org/try/rev/00a398b1fa4d4c79cf5651635bed03049378b0b2
(disable check_nsmodules because your toolchain doesn't contain a llvm-
readelf -> x86_64-blah-readelf symlink which is needed for this)
>
> I tested the x64 opt build; and it runs and loaded a few websites.
That's on Windows 10, right? I tested the artifact
(https://queue.taskcluster.net/v1/task/X5K6N8O8SMqb9RarbIrp2w/runs/0/artifacts/public/build/target.zip)
on Windows 7 and it seems to crash early on. I have not looked closer why
but I noticed that firefox.exe etc. is still linked against msvcrt.dll
which is not working for Windows 7. So, we need to teach the toolchain
again how to link against a non-default runtime lib (ucrt this time) which
has always been a fun exercise...
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28716#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs