Re: [tor-bugs] #16424 [metrics-lib]: Support parsing of .xz compressed tarballs

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#16424: Support parsing of .xz compressed tarballs
-----------------------------+----------------------------
     Reporter:  karsten      |      Owner:  karsten
         Type:  enhancement  |     Status:  needs_revision
     Priority:  normal       |  Milestone:
    Component:  metrics-lib  |    Version:
   Resolution:               |   Keywords:
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+----------------------------
Changes (by karsten):

 * status:  needs_review => needs_revision


Comment:

 Hi leeroy,

 I reviewed your 0001-Support-parsing-of-xz-compressed-tarballs.patch,
 pushed it to my public Git repository, and added some commits.  Please
 take a look at these changes and let me know if you like them or not:

 https://gitweb.torproject.org/user/karsten/metrics-
 lib.git/log/?h=task-16424

 Here's some more feedback:

  - Sorry for being picky about whitespace and code style.  I'm not at all
 saying that the styles used in metrics-lib are perfect.  We can discuss
 code style changes if you feel strongly about something.  I just think
 that being consistent is important to make the code more readable.
  - Can you create a metrics-lib (and Onionoo) repository somewhere
 (GitHub, Bitbucket, etc.) and post future patches as branches there?  That
 would make it much easier to split changes into several commits.
  - I'm yet unclear whether we should raise the Java version from 6 to 7
 for this change.  The effect is that all applications using metrics-lib
 would suddenly have to upgrade, too.  Can we postpone this upgrade?  (We'd
 have to undo the try-with-resources part.)
  - That change to the Ant build file where you include dependent jar files
 in the produced jar file seems unrelated to adding parsing support for .xz
 files.  It might be a good idea to do this, but can we postpone (as in:
 undo) this change, too?
  - I didn't test this branch yet.  It's quite possible that I broke it.

 Thanks for working on this!  Much appreciated.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16424#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs