[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #16424 [metrics-lib]: Support parsing of .xz compressed tarballs

#16424: Support parsing of .xz compressed tarballs
-----------------------------+----------------------------
     Reporter:  karsten      |      Owner:  karsten
         Type:  enhancement  |     Status:  needs_revision
     Priority:  normal       |  Milestone:
    Component:  metrics-lib  |    Version:
   Resolution:               |   Keywords:
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+----------------------------

Comment (by leeroy):

 Thank you for the feedback. Please do be picky about whitespace and style.

 Yes I will do as you suggest about the repository.

 Java 7 is additive wrt the api. Any 1.6 based applications will compile
 fine. But yes I can remove it. metrics-lib is exactly the kind of
 application that benefits from 1.7...

 Which file are you referring to? xz.jar? it '''is''' a required include.
 It's just done by libcommons-compress normally. This include makes the
 dependency clear. xz support is an '''optional''' download of libcommons-
 compress. This include detects it's absence.

 Is it the other two includes, commons-codec.jar, and commons-compress.jar?
 They are also required includes for metrics-lib functionality. The only
 reason it hasn't failed sooner is because you only use it in onionoo (and
 onionoo does the include for you). For metrics-lib to be general these
 includes are needed...

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16424#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs