[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #19528 [Applications/Tor Browser]: The build id stays the same with every Firefox update

#19528: The build id stays the same with every Firefox update
--------------------------------------+--------------------------
 Reporter:  gk                        |          Owner:  tbb-team
     Type:  defect                    |         Status:  new
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  tbb-gitian                |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+--------------------------

Comment (by gk):

 Replying to [comment:8 boklm]:
 > Replying to [comment:7 gk]:
 > > Replying to [comment:6 boklm]:
 > > > I have not yet tried doing a build using this branch. I can also
 change it to use the version from `browser/config/version.txt` rather than
 the Tor Browser version if that's better.
 > >
 > > Yes, that would be better because currently this breaks building Tor
 Browser using already built artifacts in case we don't need to rebuild the
 browser part: Users building, say 7.0.2, from scratch would get a
 different result than we which just redid the bundle part and used, say
 7.0.1, otherwise (maybe 7.0.2 just needed a newer Torbutton). So, we need
 something that changes only if a newer Firefox is built to construct
 `MOZ_BUILD_DATE`.
 >
 > However, we are already using the Tor Browser version as a firefox
 configure argument `--with-tor-browser-version=${TORBROWSER_VERSION}`
 which is then used in a few places in the updater, so we already can't
 change the Tor Browser version without rebuilding the firefox part.

 Yes, that's true. But I think the right fix is not to depend on a non-
 Firefox version number and I still have hope to get #18325 solved some
 day. :) Thus, if we can avoid it I'd be happy to not create more
 dependencies on `TORBROWSER_VERSION` in the Firefox descriptors.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19528#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs