[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #8625 [Core Tor/Tor]: Do not call networkstatus_reset_download_failures() hourly

#8625: Do not call networkstatus_reset_download_failures() hourly
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:  andrea
     Type:  defect                               |         Status:
 Priority:  High                                 |  needs_review
Component:  Core Tor/Tor                         |      Milestone:  Tor:
 Severity:  Normal                               |  0.2.9.x-final
 Keywords:  tor-client 025-backport              |        Version:
  026-triaged-1 026-deferrable tor-dos           |     Resolution:
  TorCoreTeam201607                              |  Actual Points:  3
Parent ID:                                       |         Points:  3
 Reviewer:  nickm                                |        Sponsor:
                                                 |  SponsorU-can
-------------------------------------------------+-------------------------

Comment (by nickm):

 Actual-review-points-so-far: 0

 At first glance looks okay, modulo small comments.

 Testing will be important. The important thing to consider is whether
 there are any weird cases where we are assuming that failures get reset
 often and we aren't resetting them as often as we should.  But if you
 don't find any of those in testing, I say we merge and wait to see if we
 get bugs reported?  Even if there are no actual bugs here, I expect that
 doing this will force us to re-tune some of our retry parameters a little.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8625#comment:25>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs