[tor-bugs] #22909 [Core Tor/Tor]: Our Rust code is always built in debug mode

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#22909: Our Rust code is always built in debug mode
------------------------------+-----------------------------------------
     Reporter:  isis          |      Owner:
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:  Tor: 0.3.1.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:  rust, rust-pilot, tor-build
Actual Points:                |  Parent ID:
       Points:  .1            |   Reviewer:
      Sponsor:  SponsorZ      |
------------------------------+-----------------------------------------
 In `src/rust/Cargo.toml`:

 {{{
 [profile.release]
 debug = true
 }}}

 This enables certain things, e.g. `debug_assert!(false = true)` will
 panic.  It also does stuff like bounds checks for every access and integer
 overflow/underflow checks every time any number is used.  These are great
 things to do, but they are usually done in debug builds which are used in
 ''testing'', not in release.  This will make our code literally hundreds
 of times slower, so we should probably remove this.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22909>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs