[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #22909 [Core Tor/Tor]: Our Rust code is always built in debug mode



#22909: Our Rust code is always built in debug mode
-----------------------------------------+---------------------------------
 Reporter:  isis                         |          Owner:
     Type:  defect                       |         Status:  reopened
 Priority:  Medium                       |      Milestone:  Tor:
                                         |  0.3.1.x-final
Component:  Core Tor/Tor                 |        Version:
 Severity:  Normal                       |     Resolution:
 Keywords:  rust, rust-pilot, tor-build  |  Actual Points:
Parent ID:                               |         Points:  .1
 Reviewer:                               |        Sponsor:  SponsorZ
-----------------------------------------+---------------------------------
Changes (by isis):

 * status:  closed => reopened
 * resolution:  invalid =>


Comment:

 Replying to [comment:3 Sebastian]:
 > Reason this is invalid: We're matching Tor's C code behaviour here,
 which always includes debug symbols, even in releases.

 That makes sense to try to match the C behaviour. Although, I think
 building Rust code in debug mode isn't really comparable to a C binary
 with debugging symbols… there's extra stuff going on there (like the over
 /under-flow checks), and it's not like we can just run strip on it to make
 it what it would've been without debugging enabled. It's more like
 building a C binary with UBSan and whatever other sanitisers enabled,
 which IIRC we don't do (`--enable-expensive-hardening` is off by default).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22909#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs