[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #3406 [Torctl]: High memory usage from parse_ns_body
#3406: High memory usage from parse_ns_body
--------------------+-------------------------------------------------------
Reporter: atagar | Owner:
Type: defect | Status: needs_review
Priority: normal | Milestone:
Component: Torctl | Version:
Keywords: | Parent:
Points: | Actualpoints:
--------------------+-------------------------------------------------------
Comment(by mikeperry):
Any reason why you didn't also provide the getIterator option for
get_consensus?
Incidentally, you didn't see the memory savings you expected in the
ConsensusTracker because the list itself does not occupy a lot of memory.
Think of a linked list of pointers: basically 4*length(list). The problem
is that the ConsensusTracker actually keeps all of NetworkStatus objects
around in memory in its ns_map, as well as all the Router objects
corresponding to descriptors.
You may be able to get some memory savings by altering ConsensusTracker to
optionally only track NetworkStatus documents in ns_map, and not store the
sorted_r or routers structures there. If you decide to provide the ability
to only store NetworkStatus objects, you should probably provide it by
factoring out that code into a superclass rather than an option.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3406#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs