[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #5170 [Tor]: crypto_pk_get_digest (et al.?) use i2d_RSAPublicKey obsoletely

#5170: crypto_pk_get_digest (et al.?) use i2d_RSAPublicKey obsoletely
-----------------------------+----------------------------------------------
 Reporter:  rransom          |          Owner:                    
     Type:  defect           |         Status:  needs_revision    
 Priority:  trivial          |      Milestone:  Tor: 0.2.5.x-final
Component:  Tor              |        Version:                    
 Keywords:  easy tor-client  |         Parent:                    
   Points:                   |   Actualpoints:                    
-----------------------------+----------------------------------------------
Changes (by nickm):

  * status:  needs_review => needs_revision


Comment:

 Thanks!  QUick review:

 IMO it's okay to remove id_to_fp.c in 0.2.5 if it's not even compiled.

 The "return -1" cases need to free the buffer if the buffer is non-NULL.

 In addition to the 8 calls to i2d_RSAPublicKey, there are 2 calls to
 i2d_DHParams, 2 calls to i2d_X509, and 4 calls to i2d_PublicKey. Probably,
 they could be simplified as well.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5170#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs