[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #5170 [Tor]: crypto_pk_get_digest (et al.?) use i2d_RSAPublicKey obsoletely
#5170: crypto_pk_get_digest (et al.?) use i2d_RSAPublicKey obsoletely
-----------------------------+----------------------------------------------
Reporter: rransom | Owner:
Type: defect | Status: needs_revision
Priority: trivial | Milestone: Tor: 0.2.5.x-final
Component: Tor | Version:
Keywords: easy tor-client | Parent:
Points: | Actualpoints:
-----------------------------+----------------------------------------------
Comment(by nickm):
This is looking pretty solid to me. Just a thing on one of the untested
functions:
* The unconditional openssl_free at the end of
crypto_store_dynamic_dh_modulus should probably be conditional on
dh_string_repr being non-null.
Other than that, looks good to me. I'll merge the branch and patch that.
Thanks!
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5170#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs