[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #5170 [Tor]: crypto_pk_get_digest (et al.?) use i2d_RSAPublicKey obsoletely

#5170: crypto_pk_get_digest (et al.?) use i2d_RSAPublicKey obsoletely
------------------------+---------------------------------------------------
    Reporter:  rransom  |       Owner:                    
        Type:  defect   |      Status:  closed            
    Priority:  trivial  |   Milestone:  Tor: 0.2.5.x-final
   Component:  Tor      |     Version:                    
  Resolution:  fixed    |    Keywords:  easy tor-client   
      Parent:           |      Points:                    
Actualpoints:           |  
------------------------+---------------------------------------------------
Changes (by nickm):

  * status:  needs_revision => closed
  * resolution:  => fixed


Comment:

 Merged that, plus 7f9066ceee32f4df6d94b18c7b65e92d1730fce8 and
 c94f6b228b0f6296a1fd74a5e12373754d5f07a9; thanks!

 Minor tips:
  * "make check-spaces" will tell you about some kinds of deviations from
 Tor's coding style.
  * Thanks for the link to a git branch! Once there are more than one or
 two patches in a branch, it's usually easier to merge the branch than to
 "git am" the patches, at least for me.
  * When giving people links to github branches, it's sometimes a better
 idea to give https:// links than git:// links -- the https:// links are
 authenticated.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5170#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs