[tor-bugs] #22702 [Core Tor/Tor]: Never send a consensus which the downloader already has

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#22702: Never send a consensus which the downloader already has
------------------------------+--------------------------------------------
     Reporter:  nickm         |      Owner:
         Type:  defect        |     Status:  new
     Priority:  High          |  Milestone:  Tor: 0.3.1.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:  tor-relay directory regression
Actual Points:                |  Parent ID:
       Points:  1             |   Reviewer:
      Sponsor:  Sponsor4      |
------------------------------+--------------------------------------------
 FWICT, we have a regression in our new consensus code: we no longer check
 the if-modified-since date when serving consensuses, since that field
 isn't set in the consensus_cache_entry_t case of .

 Additionally, if somebody says X-Or-Diff-From the consensus which we
 currently have, then instead of telling them "That's up-to-date", we also
 send the current consensus.  That's also bad.

 These problems make the most trouble in test networks, where the consensus
 update rate is so fast that relays frequently try to download a consensus
 before it's there.

 Diagnosed with help from ahf.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22702>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs