[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #2756 [Tor Relay]: Send stream-level sendme when outbuf is low: don't wait for it to empty!

#2756: Send stream-level sendme when outbuf is low: don't wait for it to empty!
-----------------------+----------------------------------------------------
 Reporter:  nickm      |          Owner:                    
     Type:  defect     |         Status:  needs_review      
 Priority:  normal     |      Milestone:  Tor: 0.2.2.x-final
Component:  Tor Relay  |        Version:                    
 Keywords:             |         Parent:                    
   Points:             |   Actualpoints:                    
-----------------------+----------------------------------------------------

Comment(by arma):

 The function header for connection_edge_consider_sending_sendme() needs to
 be edited too.

 I notice that connection_edge_flushed_some() and
 connection_edge_finished_flushing() both check about sending a sendme now.
 And they're called in basically the same places. The
 connection_edge_consider_sending_sendme() logic looks pretty light though,
 so I don't mind.

 Is the whole switch infrastructure needed in
 connection_edge_flushed_some()? We want to check about a sendme for all
 types of edge conns. I notice in connection_or_flushed_some() we don't
 check whether it's an OR conn.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2756#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs