[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #2756 [Tor Relay]: Send stream-level sendme when outbuf is low: don't wait for it to empty!

#2756: Send stream-level sendme when outbuf is low: don't wait for it to empty!
-----------------------+----------------------------------------------------
 Reporter:  nickm      |          Owner:                    
     Type:  defect     |         Status:  needs_review      
 Priority:  normal     |      Milestone:  Tor: 0.2.2.x-final
Component:  Tor Relay  |        Version:                    
 Keywords:             |         Parent:                    
   Points:             |   Actualpoints:                    
-----------------------+----------------------------------------------------

Comment(by nickm):

 Edited the doxygen comment (assuming that's what you mean by "header")

 I'd like to make finished_flushing and flushed_some less redundant, but
 that seems to me like an orthogonal thing to do in 0.2.3.x.

 We aren't in fact switching based on the *type* of the connection in
 connection_edge_flushed_some(); we're switching on its state.  If the
 connection isn't open, we don't want to send sendmes (because if it's an
 an AP conn that isn't open, we don't have anywhere to send them, and if
 it's an exit connection that isn't open, we shouldn't be sending sendme
 cells before we send the connected cell).

 Good to merge now?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2756#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs