Re: [tor-bugs] #15406 [Tor Browser]: Patch make_incremental_update.sh to only include forced updates if they differ?

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#15406: Patch make_incremental_update.sh to only include forced updates if they
differ?
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:  tbb-team
  mikeperry              |     Status:  new
         Type:  defect   |  Milestone:
     Priority:  normal   |    Version:
    Component:  Tor      |   Keywords:  tbb-4.5-alpha, TorBrowserTeam201503
  Browser                |  Parent ID:
   Resolution:           |
Actual Points:           |
       Points:           |
-------------------------+-------------------------------------------------

Comment (by mikeperry):

 mcs - I am asking a different question than what I asked last week on IRC.
 From my read of check_for_forced_update(), it seems we *always* include
 copies of all of our addons. So, even though HTTPS-Everywhere, torbutton,
 and tor-launcher did not change in 4.0.5, it appears as though that
 function will still cause us to include a full copy of them. This seems
 wrong.

 Is there some reason that the MAR update is checking checksums even of
 files we *don't* try to update? If so, that seems like a good reason to
 hold off on this, but it also seems like something we should fix.

 Independently, it also seems like torbutton and tor-launcher should not
 even be in this list, because we set them to be unable to update already
 (because we set both of their update urls to localhost, to prevent rogue
 versions from being listed on addons.mozilla.org and being downloaded).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/15406#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs