Re: [tor-bugs] #28329 [Applications/Tor Browser]: Design TBA+Orbot configuration UI/UX

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#28329: Design TBA+Orbot configuration UI/UX
-------------------------------------------------+-------------------------
 Reporter:  sysrqb                               |          Owner:  tbb-
                                                 |  team
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-mobile, ux-team, TBA-a3,         |  Actual Points:
  TorBrowserTeam201903, tbb-8.5                  |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor8
-------------------------------------------------+-------------------------

Comment (by gk):

 Here is the review of `28329_15`. Unless mentioned here all the issues
 mentioned in comment:39 are solved.

 General: often `if (null != $foo)` and `if ($foo != null)` are mixed,
 please stick to the latter.

 `res/drawable/ic_baseline_settings_20px.xml` - license?
 `res/drawable/list_section_divider_material.xml` - android license; where
 did the XML stuff get borrowed from  or is that an original Android file?
 `res/drawable/tor_spinning_onion.xml` - license?
 For readability (and consistency across files) newlines between XML
 header, license, and the meat of the files would be good.

 "ViewPager containing for our bootstrapping pages"

 s/containing for/for containting/ ?

 "stop bootstrapping animation"

 s/stop/stop the/

 nit: "being used.  There" <- one whitespace too much :) (in
 `TorPreferences.java`)

 "clicks on the Change link" <- missing "." at the end
 "-1 == changeStart" -> "changeStart == -1"

 "if meek-azure if chosen" -> s/if chosen/is chosen/

 Other remaining issues I had in previous comments (just to have all in one
 comment) are mentioned in comment:61 comment:46 part 1).

 A new one I saw while testing: the switch for enabling/disabling bridges
 itself is jumping a bit during the transition, probably depending on the
 text. I think the correct behavior would be that the switch stayed where
 it is and just the text "moves".

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28329#comment:62>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs