[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #33330 [Circumvention/Snowflake]: Use Go modules for Snowflake

#33330: Use Go modules for Snowflake
-------------------------------------+-----------------------------
 Reporter:  cohosh                   |          Owner:  cohosh
     Type:  defect                   |         Status:  merge_ready
 Priority:  Medium                   |      Milestone:
Component:  Circumvention/Snowflake  |        Version:
 Severity:  Normal                   |     Resolution:
 Keywords:                           |  Actual Points:
Parent ID:                           |         Points:  .2
 Reviewer:                           |        Sponsor:
-------------------------------------+-----------------------------
Changes (by dcf):

 * status:  needs_review => merge_ready


Comment:

 Looks good and works for me, thanks.

 `go mod tidy` will remove the google.golang.org/appengine dependency but
 also adds a couple more. (Honestly this is one of the most inscrutable
 parts of Go for me. All the modules commands seem to add and remove lines
 from go.mod and go.sum at random.)
 {{{#!diff
 --- a/go.mod
 +++ b/go.mod
 @@ -5,6 +5,7 @@ go 1.13
  require (
         git.torproject.org/pluggable-transports/goptlib.git v1.1.0
         github.com/dchest/uniuri v0.0.0-20200228104902-7aecb25e1fe5
 +       github.com/golang/protobuf v1.3.1 // indirect
         github.com/gorilla/websocket v1.4.1
         github.com/keroserene/go-webrtc v0.0.0-20190528223128-68a6fb1b4353
         github.com/pion/sdp/v2 v2.3.4
 @@ -12,5 +13,5 @@ require (
         github.com/smartystreets/goconvey v1.6.4
         golang.org/x/crypto v0.0.0-20200128174031-69ecbb4d6d5d
         golang.org/x/net v0.0.0-20200114155413-6afb5195e5aa
 -       google.golang.org/appengine v1.6.5
 +       golang.org/x/text v0.3.2 // indirect
  )
 }}}

 Why the new dependencies get added, I have no idea.
 {{{
 $ go mod why github.com/golang/protobuf
 # github.com/golang/protobuf
 (main module does not need package github.com/golang/protobuf)
 $ go mod why golang.org/x/text
 # golang.org/x/text
 (main module does not need package golang.org/x/text)
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33330#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs