[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #33330 [Circumvention/Snowflake]: Use Go modules for Snowflake
#33330: Use Go modules for Snowflake
-------------------------------------+-----------------------------
Reporter: cohosh | Owner: cohosh
Type: defect | Status: merge_ready
Priority: Medium | Milestone:
Component: Circumvention/Snowflake | Version:
Severity: Normal | Resolution:
Keywords: | Actual Points:
Parent ID: | Points: .2
Reviewer: | Sponsor:
-------------------------------------+-----------------------------
Comment (by cohosh):
Merged at [https://gitweb.torproject.org/pluggable-
transports/snowflake.git/commit/?id=58b52eb9f7987789d8e90a982a6df16013e200dd
6013e200dd].
Yeah this is weird. I'm still not sure why dependencies are sometimes
added with `// indirect`. As far as I can tell, they are mostly not
necessary to get a working build.
[https://github.com/golang/go/wiki/Modules#why-does-go-mod-tidy-record-
indirect-and-test-dependencies-in-my-gomod This resource] suggests that
they are required by dependencies that don't have module support, but I
suspect there's a bug in how they determine that.
Anyways, I opened #33578 to bump the version of Snowflake in Tor Browser.
This is a bit overdue as there have been several improvements since the
last update. It also includes the changes necessary since merging this
branch.
This required a few more hacks than the obfs4 project to account for the
use of v2 modules by pion-webrtc (see [https://gitweb.torproject.org
/pluggable-
transports/snowflake.git/tree/client/lib/webrtc.go?id=58b52eb9f7987789d8e90a982a6df16013e200dd#n12
here]).
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33330#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs