Re: [tor-bugs] #18616 [Core Tor/Tor]: Make begindir advertise checks consistent with DirPort checks

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#18616: Make begindir advertise checks consistent with DirPort checks
-------------------------------------------------+-------------------------
 Reporter:  toralf                               |          Owner:  andrea
     Type:  defect                               |         Status:
 Priority:  Medium                               |  needs_review
Component:  Core Tor/Tor                         |      Milestone:  Tor:
 Severity:  Normal                               |  0.2.8.x-final
 Keywords:  regression, must-fix-before-028-rc,  |        Version:  Tor:
  TorCoreTeam201605, TorCoreTeam-                |  0.2.8.1-alpha
  postponed-201604, review-group-1               |     Resolution:
Parent ID:                                       |  Actual Points:  20
 Reviewer:  arma                                 |  hours
                                                 |         Points:  medium
                                                 |        Sponsor:
-------------------------------------------------+-------------------------

Old description:

> This ticket makes sure the checks that Tor does when advertising begindir
> support are similar to the checks it does when advertising the DirPort.
>
> In particular:
> * bridges should advertise begindir support
> * authorities should always advertise begindir
> * we should never advertise begindir if the network is disabled
> * we should never advertise begindir if we don't have an ORPort
> (redundant, as we don't post descriptors without an ORPort)
> * relays should handle AccountingMax like they do for DirPort
>
> These log messages are likely unrelated to this issue:
>
> ~~This pre-0.2.8.2-alpha spews every 5-6 sec a warning (never observed
> before). Furthermore the Bug: poped up (64 bit hardened Gentoo Linux)
> {{{
> Mar 23 18:21:51.000 [warn] We just marked ourself as down. Are your
> external addresses reachable?
> Mar 23 18:21:59.000 [warn] We just marked ourself as down. Are your
> external addresses reachable?
> Mar 23 18:22:03.000 [warn] We just marked ourself as down. Are your
> external addresses reachable?
> Mar 23 18:22:09.000 [warn] We just marked ourself as down. Are your
> external addresses reachable?
> Mar 23 18:22:14.000 [warn] router_picked_poor_directory_log(): Bug:
> Firewall denied all OR and Dir addresses for all relays when searching
> for a directory. (on Tor 0.2.8.1-alpha-dev 9093e3769746742f)
> Mar 23 18:22:14.000 [warn] Bug: Node search initiated by. Stack trace:
> (on Tor 0.2.8.1-alpha-dev 9093e3769746742f)
> Mar 23 18:22:14.000 [warn] Bug:     /usr/bin/tor(+0x11e255)
> [0x55ee9e0255] (on Tor 0.2.8.1-alpha-dev 9093e3769746742f)
> Mar 23 18:22:14.000 [warn] Bug:     /usr/bin/tor(+0x624c0) [0x55ee9244c0]
> (on Tor 0.2.8.1-alpha-dev 9093e3769746742f)
> Mar 23 18:22:14.000 [warn] Bug:     /usr/bin/tor(+0x62843) [0x55ee924843]
> (on Tor 0.2.8.1-alpha-dev 9093e3769746742f)
> Mar 23 18:22:14.000 [warn] Bug:     /usr/bin/tor(+0xebb2a) [0x55ee9adb2a]
> (on Tor 0.2.8.1-alpha-dev 9093e3769746742f)
> Mar 23 18:22:14.000 [warn] Bug:     /usr/bin/tor(+0x61f75) [0x55ee923f75]
> (on Tor 0.2.8.1-alpha-dev 9093e3769746742f)
> Mar 23 18:22:14.000 [warn] Bug:     /usr/bin/tor(+0x6a0dc) [0x55ee92c0dc]
> (on Tor 0.2.8.1-alpha-dev 9093e3769746742f)
> Mar 23 18:22:14.000 [warn] Bug:     /usr/bin/tor(+0x1720d) [0x55ee8d920d]
> (on Tor 0.2.8.1-alpha-dev 9093e3769746742f)
> Mar 23 18:22:14.000 [warn] Bug:     /usr/bin/tor(+0x3208c) [0x55ee8f408c]
> (on Tor 0.2.8.1-alpha-dev 9093e3769746742f)
> Mar 23 18:22:14.000 [warn] Bug:
> /usr/lib64/libevent-2.0.so.5(event_base_loop+0x7f0) [0x3728572d830] (on
> Tor 0.2.8.1-alpha-dev 9093e3769746742f)
> Mar 23 18:22:14.000 [warn] Bug:     /usr/bin/tor(+0x1b585) [0x55ee8dd585]
> (on Tor 0.2.8.1-alpha-dev 9093e3769746742f)
> Mar 23 18:22:14.000 [warn] Bug:     /usr/bin/tor(+0x1ec05) [0x55ee8e0c05]
> (on Tor 0.2.8.1-alpha-dev 9093e3769746742f)
> Mar 23 18:22:14.000 [warn] Bug:     /usr/bin/tor(+0x16b6b) [0x55ee8d8b6b]
> (on Tor 0.2.8.1-alpha-dev 9093e3769746742f)
> Mar 23 18:22:14.000 [warn] Bug:
> /lib64/libc.so.6(__libc_start_main+0x114) [0x3728443c9e4] (on Tor 0.2.8.1
> -alpha-dev 9093e3769746742f)
> Mar 23 18:22:14.000 [warn] Bug:     /usr/bin/tor(+0x16bb9) [0x55ee8d8bb9]
> (on Tor 0.2.8.1-alpha-dev 9093e3769746742f)
> Mar 23 18:22:14.000 [warn] router info incompatible with extra info (ri
> id: 06E729BFD466279D4FCA6884DFCD9ACD64F0689A, ei id
> 06E729BFD466279D4FCA6884DFCD9ACD64F0689A, reason: Extrainfo digest did
> not match digest256 from routerdesc)
> Mar 23 18:22:14.000 [warn] router info incompatible with extra info (ri
> id: 3A1BA3B0813E1FD11833C9F430F3507662A58F43, ei id
> 3A1BA3B0813E1FD11833C9F430F3507662A58F43, reason: Extrainfo digest did
> not match digest256 from routerdesc)
> Mar 23 18:22:14.000 [warn] router info incompatible with extra info (ri
> id: D7563D50A4302B7DB3D6038637AD574E2A398D7E, ei id
> D7563D50A4302B7DB3D6038637AD574E2A398D7E, reason: Extrainfo digest
> }}}

New description:

 This ticket makes sure the checks that Tor does when advertising begindir
 support are similar to the checks it does when advertising the DirPort.

 In particular:
 * bridges should advertise begindir support
 * authorities should always advertise begindir
 * we should never advertise begindir if the network is disabled
 * we should never advertise begindir if we don't have an ORPort
 (redundant, as we don't post descriptors without an ORPort)
 * relays should handle AccountingMax like they do for DirPort

--

Comment (by arma):

 I've deleted the distracting lines while I try to wrap my head around
 this.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18616#comment:35>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs