[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #18616 [Core Tor/Tor]: Make begindir advertise checks consistent with DirPort checks
#18616: Make begindir advertise checks consistent with DirPort checks
-------------------------------------------------+-------------------------
Reporter: toralf | Owner: andrea
Type: defect | Status:
Priority: Medium | needs_review
Component: Core Tor/Tor | Milestone: Tor:
Severity: Normal | 0.2.8.x-final
Keywords: regression, must-fix-before-028-rc, | Version: Tor:
TorCoreTeam201605, TorCoreTeam- | 0.2.8.1-alpha
postponed-201604, review-group-1 | Resolution:
Parent ID: | Actual Points: 20
Reviewer: arma | hours
| Points: medium
| Sponsor:
-------------------------------------------------+-------------------------
Comment (by arma):
Here are further hints from teor about what's going on in this patch:
{{{
<teor> no, I mean we have the wrong checks
<teor> the check used to be ri->supports_tunnelled_dir_requests =
dir_server_mode(options) && router_should_be_directory_server(options,
ri->dir_port);
<teor> now it's directory_permits_begindir_requests(), which is
options->BridgeRelay != 0 || dir_server_mode(options)
<teor> that fixes a bridge issue with advertising begindir support
<teor> then we also replace router->supports_tunnelled_dir_requests with
decide_to_advertise_begindir(options,
router->supports_tunnelled_dir_requests)
<teor> which fixes a whole heap of checks that were being done for
DirPorts,
but not for begindir
}}}
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18616#comment:36>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs