[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #25975 [Applications/Tor Browser]: Get a rust cross-compiler for macOS

#25975: Get a rust cross-compiler for macOS
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-rbm, ff60-esr,                   |  Actual Points:
  TorBrowserTeam201805R, GeorgKoppen201805R,     |
  boklm201805                                    |
Parent ID:  #25779                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):

 * keywords:
     tbb-rbm, ff60-esr, TorBrowserTeam201805R, GeorgKoppen201805,
     boklm201805
     =>
     tbb-rbm, ff60-esr, TorBrowserTeam201805R, GeorgKoppen201805R,
     boklm201805
 * status:  needs_revision => needs_review
 * cc: boklm (added)


Comment:

 Actually, we are good. The reason for this problem is that we are setting
 MACOSX__DEPLOYMENT_TARGET=10.6 which fits to the current toolchain we use.
 `thread_local` is not supported for 10.6 but it is for 10.7 onward. Thus,
 we are good for now and will be later on when switching to our new
 toolchain. I just tested that and could successfully build esr60.

 I've rebased my patch on `master` and pushed an update to bug_25975_v2
 (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=bug_25975_v2&id=040cc0560eb21cf09dbdbbd33d501b805a28d6bd).

 boklm could you review that one?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25975#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs