[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #25429 [Circumvention/Snowflake]: Need something better than client's `checkForStaleness`

#25429: Need something better than client's `checkForStaleness`
--------------------------------------------+------------------------------
 Reporter:  arlolra                         |          Owner:  cohosh
     Type:  defect                          |         Status:  new
 Priority:  Medium                          |      Milestone:
Component:  Circumvention/Snowflake         |        Version:
 Severity:  Normal                          |     Resolution:
 Keywords:  anti-censorship-roadmap-2020Q1  |  Actual Points:
Parent ID:  #19001                          |         Points:
 Reviewer:                                  |        Sponsor:
                                            |  Sponsor28-must
--------------------------------------------+------------------------------

Comment (by cohosh):

 Replying to [comment:20 dcf]:
 > Replying to [comment:19 cohosh]:
 > > It looks like there's another value for `KeepAliveTimeout` in the
 [https://github.com/xtaci/smux/blob/v1.5.12/mux.go#L45 defaultConfig] and
 the session will close itself if it hasn't received any data during this
 timeout
 [https://github.com/xtaci/smux/blob/c6969d8a76874342611f4b544d05b1590f1a76b1/session.go#L393
 here]. This defaults to 30 seconds (which is the same as our current check
 for staleness).
 >
 > We override `KeepAliveTimeout` to 10 minutes
 [https://gitweb.torproject.org/pluggable-
 transports/snowflake.git/tree/client/lib/snowflake.go?id=7043a055f9fb0680281ecffd7d458a43f2ce65b5#n83
 here (client)] and [https://gitweb.torproject.org/pluggable-
 transports/snowflake.git/tree/server/server.go?id=7043a055f9fb0680281ecffd7d458a43f2ce65b5#n303
 here (server)]. If 10 minutes expire, it does indeed kill your session and
 close the SOCKS connection, but it takes many proxy failures in a row for
 that to happen.
 Ah nice! Thanks. So I guess all there is to do here is decide whether we
 want to shorten this 30 second timeout to say 15 seconds or leave it. I
 don't think it matters too much.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25429#comment:21>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs